fix(cli): state the 100-row server cap in incident feed and alert timeline --limit flag help - #147
Merged
Conversation
…eline --limit flag help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incident feed and alert timeline endpoints reject
limit > 100withInvalidParameter: Limit must be 100 or less, but the CLI's--limitflag help said only "Max events" — a caller only discovers the cap by hitting the 400. Same class as #138, which added the same note toalert list,alert-event list, andinsight incident-export.This mirrors #138's mechanism (flag-help text only) onto the two remaining feed-style verbs:
incident feed --limit(internal/cli/incident.go)alert timeline --limit(internal/cli/alert.go)The 100 cap is confirmed by the OpenAPI schema bundled in go-flashduty:
ListIncidentFeedRequest.limit("maximum": 100) andAlertFeedRequest.limit("Page size, max 100, default 20").incident timeline(the unpaginated variant) has no--limitflag and is unaffected.Verification:
make(format + lint +go test -race ./...+ build) is green; built binary shows--limit int Max events (max 100) (default 20)for both verbs;make gen-cardsproduces no diff (flag usage strings aren't embedded in the generated fences, same as #138 noted).